singularity-rs/AGENTS.md
xfy d5c0998537 docs: sync project status to shipped Phase 2 (Kerr) reality
The docs described Phase 2 as 'future work' while the code had already
shipped it: spin is wired through the uniform into the shader's Kerr deriv(),
the integrator is adaptive RK45, disk_inner is ISCO-derived, render_scale
runs a real offscreen render-to-texture + upscale pass, and the UI exposes a
Spin slider with live ISCO/Horizon readouts. Anyone reading the docs got a
wrong picture of completeness.

README:
- Intro: 'Schwarzschild' -> 'black-hole (Kerr at spin>0, Schwarzschild at 0)'.
- How it works: RK4 -> adaptive Dormand-Prince RK45; add the frame-dragging
  term to the bending accel; capture radius r+(chi); ISCO-tracked inner edge.
- Controls: add Black Hole section (Spin, ISCO/Horizon); render_scale slider.
- Performance: render_scale now wired (0.75 desktop / 0.5 web), not reserved.
- Status: Phase 1 shipped; Phase 2 implemented-pending-human-validation;
  Phase 3 (exact pseudo-Hamiltonian) is the actual future work.

AGENTS.md:
- Intro + mirror contract: name the Kerr/RK45 functions the mirror must track
  (kerr_bending_accel, rk45_step, is_captured_rk45) and the exact shader lines.
- Conventions: 'render_scale and spin are reserved' is false now — both wired;
  update the perf-lever and web-defaults notes accordingly.
- Reference docs: list both Phase 2 docs, not just Phase 1.

Phase 2 plan (docs/superpowers/plans/2026-07-13-...-kerr.md):
- Status banner: Tasks 1-7 implemented+committed, Task 8 (human visual/perf
  checklist) is what remains.
- Check the Task 1-7 step/commit boxes; leave all Task 8 manual steps and the
  visual/fps acceptance items unchecked. Check only the code-verifiable
  acceptance items (cargo test green, RK45+render_scale running, Spin slider
  shipped).
2026-07-14 15:52:49 +08:00

6.6 KiB
Raw Blame History

AGENTS.md

A real-time Kerr (spinning) black-hole renderer in Bevy 0.19. One binary, two targets: desktop and web/WebGPU. Spin χ = 0 degenerates exactly to Schwarzschild.

Build & run

  • Desktop: cargo run --release (debug build is too slow to ray-trace; always use --release for visual checks).
  • Web (WebGPU only): trunk servehttp://127.0.0.1:8080. First-time setup: cargo install --locked trunk and rustup target add wasm32-unknown-unknown. Release web build: trunk build --release.
  • .cargo/config.toml sets --cfg web_sys_unstable_apis for the wasm32 target only — required for web-sys's WebGPU bindings. It is a no-op on desktop; do not remove it.
  • edition = "2024". No pinned toolchain file; tested on stable 1.96.
  • target/ and dist/ are gitignored. The dist/ folder may contain a ~200 MB wasm build locally — never commit it.

Test

  • cargo test. There is exactly one testable surface: src/physics.rs (inline #[cfg(test)]) + tests/physics_test.rs (integration test via the singularity_rs::physics lib export). src/lib.rs exists solely to expose physics for these tests.
  • The GPU shader is not unit-tested. The whole point of physics.rs is to be a CPU mirror that is testable.

Architecture: the CPU ↔ shader mirror

The real renderer is a single full-screen quad running assets/shaders/black_hole.wgsl (Kerr geodesic integration via an adaptive Dormand-Prince RK45 loop + disk/planets/grid/star compositing), rendered into a sub-resolution offscreen Image and upscaled to the window by a second camera (render_scale). src/physics.rs is a hand-maintained CPU mirror of that integrator, kept so the capture-vs-escape boundary is unit-testable on the CPU.

Changing physics in one place means updating the other. bending_accel / kerr_bending_accel / rk45_step / is_captured / is_captured_rk45 in physics.rs must stay in lockstep with the shader's deriv / rk45_step / integration loop, or the tests will pass on code that the shader contradicts. The mirror covers: the single-step Kerr derivative (kerr_bending_accelderiv), the adaptive step (rk45_step ↔ shader rk45_step), and the full loop (is_captured_rk45 ↔ the loop at black_hole.wgsl:320-390, including the budget = accepted-steps-only rule and the dt_min forced-accept floor).

Module wiring (entrypoints):

  • main.rs — app entry, web fallback gate, plugin wiring (render::BlackHolePlugin).
  • render/plugin.rs — the BlackHolePlugin: spawns the fullscreen quad + Camera2d, mirrors params to the GPU uniform each frame.
  • render/material.rsBlackHoleMaterial (Material2d) + BlackHoleUniforms / SphereData structs.
  • camera.rs — orbit controller (yaw/pitch/zoom) + WantsPointer (disables orbit over the UI panel).
  • params.rsBlackHoleParams resource, edited live by the egui panel, mirrored into the material each frame.
  • scene/planets.rsPlanet component + storage-buffer upload.
  • ui.rs — egui Controls panel.
  • web.rs — wasm-only: WebGPU detection + fallback message.

Bevy 0.19 gotchas (cause of the recurring "grey screen")

Three things that silently produce a grey/frozen canvas if broken — recent commits on this branch exist precisely to fix these:

  1. nudge_camera (render/plugin.rs) works around Bevy 0.19 issue #24448: a static Camera2d stops rendering after the first frame. It oscillates the camera by a sub-pixel amount each frame. Do not remove it expecting a cleanup.
  2. bevy_egui 0.41 requires UI systems to run in EguiPrimaryContextPass, not Update. Placing ui_system in Update panics.
  3. The planets storage buffer must be a real ShaderBuffer asset, not Handle::default(). A default handle makes AsBindGroup return RetryNextUpdate every frame, silently skipping the quad's draw — the screen shows only the camera clear color. The quad is pre-filled with a MAX_PLANETS-sized zeroed buffer at startup; upload_planets updates it.

When debugging a blank/grey screen, check these three before the shader.

Conventions

  • Natural units: Rs = 1 throughout (Rust + WGSL). BCRIT = 3√3/2·Rs ≈ 2.598 is a literal in physics.rs because f32::sqrt isn't const; the integration test guards the literal.
  • spin and render_scale are both wired (Phase 2). spin (dimensionless χ = a/M ∈ [0,1]) drives the Kerr frame-dragging term in the shader's deriv and a spin-dependent capture radius (r₊); the disk inner edge is derived from kerr_isco(spin) in mirror_params. render_scale renders the black-hole quad into an offscreen Image at sub-resolution and a second camera upscales it (see render/plugin.rs: OffscreenTarget / OffscreenCamera / UpscaleCamera). The #[allow(dead_code)] on BlackHoleParams is now only for spin's historical reservation — both fields are live.
  • Both steps and render_scale are performance levers. steps caps accepted RK45 steps per ray; render_scale lowers the offscreen resolution. The RK45 integrator is ~an order of magnitude costlier than Phase 1's fixed-step RK4, so the default render_scale dropped to 0.75 (desktop) / 0.5 (web).
  • Web defaults differ via cfg!(target_arch = "wasm32"): steps 200 (web) vs 300 (desktop), render_scale 0.5 vs 0.75.

Git workflow

  • After finishing a change, decide for yourself whether it should be committed — don't stop and ask. Commit when the work forms a coherent, complete unit (a fix builds, tests pass, code compiles); hold off only if it's mid-flight or known-broken.
  • Commits are granular and detailed. Split by concern: one logical change per commit, not one giant dump. The message explains what and why (the gotcha it fixes, the invariant it restores), not just a restatement of the diff.
  • Never push. Local commits only; leave pushing to the human.

Reference docs

  • README.md — controls, how-it-works, project layout, status.
  • docs/superpowers/specs/2026-07-09-interstellar-blackhole-design.md — Phase 1 (Schwarzschild) design spec.
  • docs/superpowers/plans/2026-07-09-interstellar-blackhole-phase1.md — Phase 1 implementation plan.
  • docs/superpowers/specs/2026-07-13-interstellar-blackhole-phase2-kerr-design.md — Phase 2 (Kerr) design spec.
  • docs/superpowers/plans/2026-07-13-interstellar-blackhole-phase2-kerr.md — Phase 2 implementation plan (Tasks 17 done; Task 8 is the human visual/perf validation).

Skills

This repo has Matt Pocock's engineering skills vendored under .agents/skills/ and pinned in skills-lock.json (e.g. tdd, code-review, diagnosing-bugs, codebase-design). They are workspace-scoped and load automatically.