GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 01:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(channel): redundant channel_close()

Browse Source 
Problem:
`receive_msgpack()` calls `channel_close()` just before calling
`chan_close_on_err()`, even though `chan_close_on_err()` always calls
`channel_close()`.

Solution:
Remove the redunant `channel_close()` in `receive_msgpack()`.
This commit is contained in:
Justin M. Keyes
2025-03-24 17:38:34 +01:00
parent 563051a53e
commit e73a3f1edc
4 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/nvim/event/rstream.c
View File

@ -184,6 +184,7 @@ static void read_event(void **argv)
}
stream->s.pending_reqs--;
if (stream->s.closed && !stream->s.pending_reqs) {
// Last pending read; free the stream.
stream_close_handle(&stream->s, true);
}
}

2
src/nvim/event/stream.c
View File

@ -120,7 +120,7 @@ void stream_may_close(Stream *stream, bool rstream)
if (!stream->pending_reqs) {
stream_close_handle(stream, rstream);
}
} // Else: rstream.c:read_event() or wstream.c:write_cb() will call stream_close_handle().
}
void stream_close_handle(Stream *stream, bool rstream)

2
src/nvim/event/wstream.c
View File

@ -156,7 +156,7 @@ static void write_cb(uv_write_t *req, int status)
data->stream->pending_reqs--;
if (data->stream->closed && data->stream->pending_reqs == 0) {
// Last pending write, free the stream;
// Last pending write; free the stream.
stream_close_handle(data->stream, false);
}

16
src/nvim/msgpack_rpc/channel.c
View File

@ -222,10 +222,9 @@ static size_t receive_msgpack(RStream *stream, const char *rbuf, size_t c, void
}
if (eof) {
channel_close(channel->id, kChannelPartRpc, NULL);
char buf[256];
snprintf(buf, sizeof(buf), "ch %" PRIu64 " was closed by the peer", channel->id);
chan_close_with_error(channel, buf, LOGLVL_INF);
chan_close_on_err(channel, buf, LOGLVL_INF);
}
channel_decref(channel);
@ -268,7 +267,7 @@ static void parse_msgpack(Channel *channel)
"ch %" PRIu64 " (type=%" PRIu32 ") returned a response with an unknown request "
"id %" PRIu32 ". Ensure the client is properly synchronized",
channel->id, (unsigned)channel->rpc.client_type, p->request_id);
chan_close_with_error(channel, buf, LOGLVL_ERR);
chan_close_on_err(channel, buf, LOGLVL_ERR);
return;
}
frame->returned = true;
@ -292,7 +291,7 @@ static void parse_msgpack(Channel *channel)
Object res = p->result;
if (p->result.type != kObjectTypeArray) {
chan_close_with_error(channel, "msgpack-rpc request args must be an array", LOGLVL_ERR);
chan_close_on_err(channel, "msgpack-rpc request args must be an array", LOGLVL_ERR);
return;
}
Array arg = res.data.array;
@ -301,7 +300,7 @@ static void parse_msgpack(Channel *channel)
}
if (unpacker_closed(p)) {
chan_close_with_error(channel, p->unpack_error.msg, LOGLVL_INF);
chan_close_on_err(channel, p->unpack_error.msg, LOGLVL_INF);
api_clear_error(&p->unpack_error);
}
}
@ -419,7 +418,7 @@ static bool channel_write(Channel *channel, WBuffer *buffer)
"ch %" PRIu64 ": stream write failed. "
"RPC canceled; closing channel",
channel->id);
chan_close_with_error(channel, buf, LOGLVL_ERR);
chan_close_on_err(channel, buf, LOGLVL_ERR);
}
return success;
@ -438,7 +437,7 @@ static void internal_read_event(void **argv)
if (p->read_size) {
// This should not happen, as WBuffer is one single serialized message.
if (!channel->rpc.closed) {
chan_close_with_error(channel, "internal channel: internal error", LOGLVL_ERR);
chan_close_on_err(channel, "internal channel: internal error", LOGLVL_ERR);
}
}
@ -519,7 +518,8 @@ void rpc_free(Channel *channel)
api_free_dict(channel->rpc.info);
}
static void chan_close_with_error(Channel *channel, char *msg, int loglevel)
/// Logs a fatal error received from a channel, then closes the channel.
static void chan_close_on_err(Channel *channel, char *msg, int loglevel)
{
LOG(loglevel, "RPC: %s", msg);
for (size_t i = 0; i < kv_size(channel->rpc.call_stack); i++) {