GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 01:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Backport release-0.8] fix(api): nvim_create_autocmd crash on invalid types inside pattern array (#21777)

Browse Source 
fix(api): nvim_create_autocmd crash on invalid types inside pattern array

(cherry picked from commit 46cef24321)

Co-authored-by: ii14 <ii14@users.noreply.github.com>
This commit is contained in:
github-actions[bot]
2023-01-12 09:28:32 -08:00
committed by GitHub
parent 2b512a1d25
commit 5d5a155685
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/api/autocmd.c
View File

@ -972,7 +972,7 @@ static bool get_patterns_from_pattern_or_buf(Array *patterns, Object pattern, Ob
patlen = aucmd_pattern_length(pat);
}
} else if (v->type == kObjectTypeArray) {
if (!check_autocmd_string_array(*patterns, "pattern", err)) {
if (!check_autocmd_string_array(v->data.array, "pattern", err)) {
return false;
}

14
test/functional/api/autocmd_spec.lua
View File

@ -613,6 +613,20 @@ describe('autocmd api', function()
eq(false, success)
matches("'group' must be a string or an integer", code)
end)
it('raises error for invalid pattern array', function()
local success, code = unpack(meths.exec_lua([[
return {pcall(function()
vim.api.nvim_create_autocmd("FileType", {
pattern = {{}},
command = "echo 'hello'",
})
end)}
]], {}))
eq(false, success)
matches("All entries in 'pattern' must be strings", code)
end)
end)
describe('patterns', function()