xfy/yggdrasil
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
1,099 Commits 1 Branch 8 Tags
Commit Graph

34 Commits

Author SHA1 Message Date
xfy
799455da43 feat(assets): 删除保护、孤儿清理与 alt 编辑 
- delete_asset：引用中业务拒绝（Ok(success:false) + 引用文章列表），
  孤儿硬删除（文件 + DB 行级联 refs + 派生缓存）
- purge_orphan_assets：一键清理无引用且超过 7 天保护窗的素材，
  容忍单项文件删除失败，返回数量/释放字节/失败数
- update_asset_alt：管理性 alt 编辑
- invalidate_asset_caches：IMAGE_CACHE 前缀批量失效 + 尺寸缓存失效；
  磁盘派生缓存（哈希命名不可枚举）由既有清理任务回收
- 前端：卡片操作区三态（复制/alt/删除 ↔ alt 编辑 ↔ 确认删除），
  顶栏「清理孤儿」两步确认（带数量与总大小），操作结果横幅
 2026-07-24 16:23:00 +08:00
xfy
0c811efd4d feat(assets): 素材注册表数据层 
- migration 015：assets 元数据注册表 + asset_refs 引用关联表
- upload_image 落盘后登记 assets（失败补偿删文件）；尺寸校验复用
  upload_dimensions 一次解析同时返回 (w,h)
- sync_asset_refs 镜像 sync_tags：文章 create/update 事务内
  解析 content_html + cover_image 的 /uploads/ 路径重建引用
- Asset/AssetDto/AssetFilter/AssetSort 共享模型，id 以 String 承载
  （SQL 侧 ::uuid cast，避免 uuid crate 进 WASM 构建）
 2026-07-24 16:07:07 +08:00
xfy
690e00e194 refactor(unwrap): 消除非测试代码中的裸 .unwrap()，改为带不变量说明的 .expect() 
panic="abort" 下任何 panic 直接杀进程，与 unwrap 的「稍后处理」语义冲突。
本轮把所有可证不变量的裸 unwrap 改写为带说明的 expect，并修复 time.rs 中
u32→i32 转换在大 ms 值下的潜在溢出 panic（clamp 到 i32::MAX）。

- src/utils/time.rs: sleep_ms 的 ms.try_into().unwrap() 改为 clamp 到
  i32::MAX，避免超大延时值溢出；window/set_timeout 的 expect 补充上下文说明
- src/utils/text.rs: 6 个静态正则的 unwrap 改为 expect，统一说明「编译期校验」
- src/api/{auth,comments/helpers}.rs: EMAIL_REGEX 同上
- src/api/markdown.rs: IMG_RE / TABLE_RE 同上
- src/api/rate_limit.rs: NonZeroU32::new(val.max(1)) 与 Quota::with_period
  补充不变量说明
- src/api/image.rs: HeaderValue::from_str(&etag).unwrap() 改为 expect 说明
  etag 仅含 ASCII hex；复用 etag_value 避免 clone
- src/middleware.rs: 静态 302 重定向响应的 unwrap 改为 expect
- src/components/post/post_content.rs、src/theme.rs: WASM 上下文 window().unwrap()
  改为 expect 说明仅浏览器执行

保留的 unwrap/expect（合理不变量，已在注释中说明）：
- DB_POOL LazyLock 闭包（已有详细注释 + validate_database_url 前置校验）
- csrf.rs 静态 forbidden 响应
- highlight.rs syntect 内置 Plain Text 语法
- bin/generate_highlight_css 构建工具
- comments/* 的 #[cfg(not(server))] unreachable!() WASM stub
 2026-07-23 18:26:19 +08:00
xfy
acfdfb03f5 fix(image): 为 ImageFmt 别名补上 #[cfg(feature = "server")] 门控 
type ImageFmt = image::ImageFormat 未加 server feature 门控，
而 image crate 是 server-only 可选依赖。WASM 构建 (web feature)
解析到该别名时找不到 image crate，报 E0433。

detect_format (唯一使用方) 已有 #[cfg(feature = "server")]，
测试也在 #[cfg(all(test, feature = "server"))] 下，别名只需对齐门控。
 2026-07-15 13:30:38 +08:00
xfy
8efd8c8021 perf(image): cache_key 单次拼接 + detect_format 零分配后缀匹配
Some checks failed
CI / check (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details 
cache_key：旧实现 vec![path.to_string()] + 最多 6 个 format! + join，
最坏 9 次堆分配（path clone + 6 个参数 String + Vec 指针数组 + join String）。
改用 with_capacity + write! 直写，1 次分配。每次未命中缓存的图片请求都走。

detect_format：旧实现对整条路径 to_lowercase() 分配 String，只为查后缀。
改用 rsplit('.').next() 取后缀 + eq_ignore_ascii_case 零分配匹配。
每次图片请求调用 1-2 次。

注：rotate 在 resize 之前是刻意设计（让 w/h 作用于旋转后的最终方向），
不动以保持 URL 语义与缓存一致性。
 2026-07-15 11:48:59 +08:00
xfy
6837b4cfa2 refactor(image): 合并维度读取函数，共享 image_reader_limits 
提取 read_webp_dimensions / read_image_dimensions 两个核心函数，
read_dimensions_by_mime 与 read_dimensions_from_bytes 各自只负责
格式映射（MIME→format / 扩展名→format），消除 zenwebp 调用与
into_dimensions 逻辑的双份实现。

附带收紧：read_dimensions_from_bytes 原用 with_guessed_format() 猜测
格式，现改为按扩展名显式匹配，避免猜测错误。

image_reader_limits() 改为 pub(crate)，upload.rs 的内联 limits 构造
（4 行逐字重复）改为调用共享函数。
 2026-07-14 15:13:21 +08:00
xfy
373498870a style: apply cargo fmt to workspace
Some checks failed
CI / check (push) Failing after 5m35s
Details
CI / build (push) Has been skipped
Details
2026-06-29 13:47:40 +08:00
xfy
ff2694c5a3 feat(image): make size/pixel limits configurable, double defaults
Some checks failed
CI / check (push) Failing after 6m23s
Details
CI / build (push) Has been skipped
Details 
将 MAX_IMAGE_DIMENSION / MAX_IMAGE_PIXELS 从编译期 const 改为运行时
LazyLock(启动读环境变量),默认值 x2。

- 默认值:单边 4096→8192,总像素 25M→50M
- clamp 策略:只设下限防危险小值(DIMENSION≥512,PIXELS≥1M),
  超下限 clamp + warn;无上限,完全信任运维
- 内存影响:默认 50M 像素对应 ~200MB/图解码缓冲(max_alloc)
- 模式复用 WEBP_CONFIG:env→parse→(val,clamped)→clamp→warn→info
- 所有引用点解引用(*MAX_...),含 upload.rs/webp.rs 跨文件
- check_upload_dimensions 超限文案改为动态读取上限,不再硬编码数值
- 测试改用 *MAX_IMAGE_DIMENSION+1,数值无关

.env.example 与 AGENTS.md 同步更新环境变量说明。
 2026-06-24 13:54:36 +08:00
xfy
0777fd469a fix(upload): unify image size limit across all formats 
上传入口此前对超大图片行为不一致:JPEG/PNG 因 decode limits 失败后
静默存原图,WebP 报"损坏",GIF 完全不查。统一为 header 阶段硬拒绝。

- image.rs: 新增 check_upload_dimensions,按 MIME 只读 header 拿尺寸
  (WebP 走 zenwebp header,JPEG/PNG/GIF 走 image into_dimensions),
  超 MAX_IMAGE_DIMENSION/MAX_IMAGE_PIXELS 返回友好提示
- upload.rs: magic bytes 校验后插入统一尺寸校验,三种格式同路径
- upload.rs: JPEG/PNG 转码 fallback 的 Err(_) 改为 Err(e) 带原因日志
  (超限已在 header 阶段拦截,此处仅剩真损坏兜底)

读取侧 serve_image 不动;webp::decode 内的像素校验保留(读取侧仍需)。
 2026-06-24 13:25:23 +08:00
xfy
45d14e2ad9 feat(image): add image dimensions cache with header-only reading 2026-06-22 17:55:16 +08:00
xfy
d1e08ec402 fix(image): write disk cache atomically via temp-file + rename 
.dat/.ct 改为先写 .tmp 再 rename，避免并发请求读到内容与 content-type
错配的半成品文件（L5）。写失败或 rename 失败时清理临时文件与目标。
 2026-06-18 13:40:48 +08:00
xfy
3723cd03f9 fix(image): add canonicalize prefix check to is_path_safe for defense in depth 
子串检查之外，对已存在文件做 canonicalize 前缀校验，确认解析后路径仍在
uploads 目录内，抵御符号链接等绕过（L4）。文件或 uploads 目录不存在时
只靠第一层校验（交由后续读取报 404）。函数改为 async，调用点与测试同步更新。
 2026-06-18 13:39:46 +08:00
xfy
7a6e9350fe fix(image): reject undecodable images with 422; cap raw file size at 20MB 
- decode 失败（WebP 与其他格式）不再降级返回原始字节，防止构造的畸形文件以
  图片 content-type 返回任意内容（M3）
- 原始分支读前查 metadata，超 20MB 返回 413，避免超大文件撑爆内存
 2026-06-18 13:38:03 +08:00
xfy
22e883c6d9 fix(image): add X-Content-Type-Options: nosniff to all image responses 
304 与 200 两个分支都附加 nosniff，防止浏览器对 content-type 错配的图片字节
做 MIME sniff（M2）。配合原始文件分支按扩展名决定 content-type 的行为做纵深防御。
 2026-06-18 13:36:39 +08:00
xfy
a71da7473d perf(image): remove redundant Vec clone before spawn_blocking 2026-06-18 10:10:44 +08:00
xfy
36554af5f5 perf(image): store cached image data as Bytes to avoid Vec cloning 2026-06-18 10:03:35 +08:00
xfy
abdfd2e3f9 fix: make If-None-Match comparison RFC 7232 compliant 2026-06-17 14:14:37 +08:00
xfy
27ce878771 feat: support If-None-Match 304 for image responses 2026-06-17 14:08:45 +08:00
xfy
21b665f41d feat: add Cache-Control and ETag headers for image responses 2026-06-17 13:59:17 +08:00
xfy
fe6e5bd045 perf: offload image decode/resize/encode to spawn_blocking 2026-06-17 13:52:05 +08:00
xfy
7bad3ce382 fix: make ConnectInfo optional in serve_image to prevent 500 2026-06-17 13:40:17 +08:00
xfy
449a545886 security: fix critical issues from repository review
Some checks failed
CI / build (push) Has been cancelled
Details
CI / check (push) Has been cancelled
Details 
P0 blockers:
- Fix migration numbering conflict and duplicate indexes
- Change comments.post_id FK to ON DELETE CASCADE
- Restrict public post detail endpoint to published posts only
- Fix rate-limiting IP extraction and fallback to ConnectInfo
- Harden HTML sanitizer: deny unknown URL schemes, restrict data URIs
- Remove session token from login response body
- Enforce image pixel/dimension limits on upload and serving

P1 high-risk:
- Validate uploads by magic bytes and decode GIF/WebP
- Add pagination/rate-limiting to search, tag posts, and comments
- Make first-admin registration and slug uniqueness check atomic
- HTML-escape comment author fields
- Improve HTML minify cache key and skip admin/error responses
- Add mobile navigation menu

P2 accessibility/quality:
- Associate form labels with inputs
- Key PostDetail article by slug to re-init scripts on navigation
- Improve image viewer keyboard accessibility
- Make theme toggle SSR-friendly and add aria-label
- Invalidate slug 404 cache on create and pending count on new comment
- Deduplicate tags case-insensitively

P3 cleanup:
- Remove unused tower-http dependency, expand make clean
- Configure DB pool timeouts and verified recycling
- Run background cleanup tasks immediately on startup
- Use SHA-256 for stable disk cache keys
- Log DB errors with Display instead of Debug
- Update README migration instructions

All tests pass (321), clippy clean, dx check clean.
 2026-06-17 10:34:14 +08:00
xfy
26b012c40c docs(api, auth): 补充中文注释 2026-06-12 18:27:24 +08:00
xfy
294d60afab style: format rust code
Some checks failed
CI / build (push) Has been cancelled
Details
CI / check (push) Has been cancelled
Details
2026-06-12 17:14:31 +08:00
xfy
db3379364f fix: limit WebP decode buffer size to prevent malicious allocations 2026-06-09 15:48:34 +08:00
xfy
7c6bab8019 fix: preserve f32 precision for WebP quality 2026-06-09 15:43:16 +08:00
xfy
2e2be7b16d feat: add WebP encoding support with zenwebp 
- Replace image crate's WebP with zenwebp for better quality/speed
- Add webp.rs module with configurable quality and method
- Update .env.example with WEBP_QUALITY and WEBP_METHOD
- Add WebP decode support in image serving pipeline
- Add detailed timing logs for WebP conversion
 2026-06-09 15:30:06 +08:00
xfy
5ecd8a9b86 feat: add disk-level cache for processed image variants 2026-06-09 13:45:49 +08:00
xfy
3974856f3d fix: resolve image/upload 500 errors and refactor rate limiting 
- Separate /uploads and /api/upload routes from Dioxus app to avoid
  IncrementalRenderer intercepting non-page requests
- Remove broken SmartIpKeyExtractor-based general_limit() that failed
  under Dioxus dev server proxy (Unable To Extract Key)
- Move rate limiting into handlers using governor::RateLimiter directly
- Add IMAGE_LIMITER for /uploads/* serving
- Make all rate limits configurable via environment variables
- Add rate limit config to .env.example with sensible defaults
 2026-06-09 09:48:51 +08:00
xfy
4f368e6fb8 test: add 122 unit tests across 12 modules 
Cover utils/text, api/slug, auth/password, auth/session,
models/post, models/user, api/auth validation, api/markdown,
api/image, highlight, api/rate_limit. Add make test target.
 2026-06-09 09:25:44 +08:00
xfy
2c08c6c7fd fix(image): case-insensitive format matching in process_image 2026-06-08 15:29:17 +08:00
xfy
8b1b949bf8 refactor: apply formatting to image.rs 2026-06-08 15:13:18 +08:00
xfy
d584ef6e00 fix(image): improve cache keys, case-insensitive format, strict thumb validation 2026-06-08 15:13:18 +08:00
xfy
1f009f57c8 feat: add image processing handler with resize/thumbnail/rotate/format 2026-06-08 15:13:18 +08:00