lolly/internal/proxy/cache_key_allocation_test.go
xfy b5c3c0954f
Some checks failed
CI / Test (push) Failing after 23s
CI / Build (push) Has been skipped
fix: address repository review issues
Security:
- Enforce client_max_body_size in HTTP/2 and HTTP/3 adapters before buffering
- Use trusted-proxy-aware client IP extraction for access control and rate limiting
- Include Host and Vary headers in proxy cache key to prevent cache poisoning
- Harden static file path traversal check with filepath.Clean + prefix validation
- Honor proxy_ssl config for WebSocket upstream TLS

Proxy/handler bugs:
- Decrement WebSocket connection count immediately on return (not deferred in retry loop)
- Remove ineffective headersPool
- Coalesce concurrent background cache refreshes with singleflight

Dev/build:
- Fix Makefile run and test-config targets
- Remove broken wget healthcheck from docker-compose
- Add missing integration build tags
- Fix go vet warnings in tests

CI:
- Run golangci-lint and integration tests in Gitea Actions

Refs: docs/superpowers/plans/2026-06-17-fix-review-issues.md
2026-06-17 11:17:53 +08:00

111 lines
2.7 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Package proxy 提供代理缓存键零分配验证测试。
//
// 该文件验证 buildCacheKeyHashValue 的零分配优化效果。
//
// 测试场景:
// - buildCacheKeyHashValue: 直接哈希,目标 0 allocs/op
// - buildCacheKeyHash: 字符串构建,对比基准
//
// 作者xfy
package proxy
import (
"testing"
"github.com/valyala/fasthttp"
"rua.plus/lolly/internal/config"
"rua.plus/lolly/internal/loadbalance"
)
// BenchmarkCacheKeyHashValue_ZeroAlloc 验证零分配路径。
//
// buildCacheKeyHashValue 直接写入哈希,不分配字符串。
func BenchmarkCacheKeyHashValue_ZeroAlloc(b *testing.B) {
p, err := NewProxy(&config.ProxyConfig{
Path: "/api",
LoadBalance: "round_robin",
Timeout: config.ProxyTimeout{
Connect: 5 * 1e9,
Read: 30 * 1e9,
Write: 30 * 1e9,
},
}, []*loadbalance.Target{{URL: "http://localhost:8080"}}, nil, nil)
if err != nil {
b.Fatalf("NewProxy() error: %v", err)
}
ctx := &fasthttp.RequestCtx{}
ctx.Request.Header.SetMethod(fasthttp.MethodGet)
ctx.Request.SetRequestURI("/api/test?query=value&foo=bar")
b.ReportAllocs()
b.ResetTimer()
for b.Loop() {
hash := p.buildCacheKeyHashValue(ctx, nil)
_ = hash
}
}
// BenchmarkCacheKeyHash_WithAlloc 对比带分配的字符串构建路径。
//
// buildCacheKeyHash 分配字符串用于 origKey 返回值。
func BenchmarkCacheKeyHash_WithAlloc(b *testing.B) {
p, err := NewProxy(&config.ProxyConfig{
Path: "/api",
LoadBalance: "round_robin",
Timeout: config.ProxyTimeout{
Connect: 5 * 1e9,
Read: 30 * 1e9,
Write: 30 * 1e9,
},
}, []*loadbalance.Target{{URL: "http://localhost:8080"}}, nil, nil)
if err != nil {
b.Fatalf("NewProxy() error: %v", err)
}
ctx := &fasthttp.RequestCtx{}
ctx.Request.Header.SetMethod(fasthttp.MethodGet)
ctx.Request.SetRequestURI("/api/test?query=value&foo=bar")
b.ReportAllocs()
b.ResetTimer()
for b.Loop() {
hash, key := p.buildCacheKeyHash(ctx, nil)
_ = hash
_ = key
}
}
// BenchmarkCacheKeyHash_Compare 并行对比两种方法。
func BenchmarkCacheKeyHash_Compare(b *testing.B) {
p, err := NewProxy(&config.ProxyConfig{
Path: "/api",
LoadBalance: "round_robin",
}, []*loadbalance.Target{{URL: "http://localhost:8080"}}, nil, nil)
if err != nil {
b.Fatalf("NewProxy() error: %v", err)
}
ctx := &fasthttp.RequestCtx{}
ctx.Request.Header.SetMethod(fasthttp.MethodGet)
ctx.Request.SetRequestURI("/api/data?id=123&sort=desc")
b.Run("ZeroAlloc", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for b.Loop() {
_ = p.buildCacheKeyHashValue(ctx, nil)
}
})
b.Run("WithAlloc", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for b.Loop() {
_, _ = p.buildCacheKeyHash(ctx, nil)
}
})
}