xfy
d21e27fbac
主要修复： - errcheck: defer Close 使用 //nolint:errcheck，类型断言改为 ok 检查 - govet fieldalignment: 调整结构体字段顺序优化内存布局 - revive unused-parameter: 将未使用参数改为 _ - exhaustive: 添加缺失的 switch case 或 default - goconst: 提取重复字符串为常量 (accessAllow, accessDeny 等) - staticcheck SA9003: 修复空分支逻辑 - gofmt: 运行 gofmt -w 格式化 - nolintlint: 修复 nolint 注释格式 其他改进： - 更新 .golangci.yml 配置，启用更严格的检查 - 移除未使用的代码和导入 - 简化测试辅助函数调用 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
466 lines
12 KiB
Go
466 lines
12 KiB
Go
// Package stream 提供 TCP/UDP Stream 代理功能。
|
||
//
|
||
// 该文件包含 Stream SSL/TLS 支持的单元测试。
|
||
//
|
||
// 作者：xfy
|
||
package stream
|
||
|
||
import (
|
||
"crypto/rand"
|
||
"crypto/rsa"
|
||
"crypto/tls"
|
||
"crypto/x509"
|
||
"encoding/pem"
|
||
"math/big"
|
||
"os"
|
||
"path/filepath"
|
||
"testing"
|
||
"time"
|
||
|
||
"rua.plus/lolly/internal/config"
|
||
"rua.plus/lolly/internal/sslutil"
|
||
)
|
||
|
||
// generateTestCertificate 生成测试用的自签名证书
|
||
func generateTestCertificate(t *testing.T, certFile, keyFile string) {
|
||
t.Helper()
|
||
|
||
// 创建证书模板
|
||
template := &x509.Certificate{
|
||
SerialNumber: big.NewInt(1),
|
||
NotBefore: time.Now(),
|
||
NotAfter: time.Now().Add(24 * time.Hour),
|
||
KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
|
||
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
|
||
BasicConstraintsValid: true,
|
||
DNSNames: []string{"localhost"},
|
||
}
|
||
|
||
// 生成私钥和证书
|
||
key, err := rsa.GenerateKey(rand.Reader, 2048)
|
||
if err != nil {
|
||
t.Fatalf("Failed to generate key: %v", err)
|
||
}
|
||
|
||
certDER, err := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create certificate: %v", err)
|
||
}
|
||
|
||
// 写入证书文件
|
||
certOut, err := os.Create(certFile)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create cert file: %v", err)
|
||
}
|
||
defer func() { _ = certOut.Close() }()
|
||
if err := pem.Encode(certOut, &pem.Block{Type: "CERTIFICATE", Bytes: certDER}); err != nil {
|
||
t.Fatalf("Failed to encode certificate: %v", err)
|
||
}
|
||
|
||
// 写入私钥文件
|
||
keyOut, err := os.Create(keyFile)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create key file: %v", err)
|
||
}
|
||
defer func() { _ = keyOut.Close() }()
|
||
if err := pem.Encode(keyOut, &pem.Block{Type: "RSA PRIVATE KEY", Bytes: x509.MarshalPKCS1PrivateKey(key)}); err != nil {
|
||
t.Fatalf("Failed to encode key: %v", err)
|
||
}
|
||
}
|
||
|
||
func TestNewSSLManager_Disabled(t *testing.T) {
|
||
cfg := config.StreamSSLConfig{
|
||
Enabled: false,
|
||
}
|
||
|
||
mgr, err := NewSSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewSSLManager failed: %v", err)
|
||
}
|
||
|
||
if mgr.IsEnabled() {
|
||
t.Error("Expected IsEnabled to be false")
|
||
}
|
||
|
||
tlsConfig := mgr.GetTLSConfig()
|
||
if tlsConfig != nil {
|
||
t.Error("Expected nil TLS config when disabled")
|
||
}
|
||
}
|
||
|
||
func TestNewSSLManager_Enabled(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
certFile := filepath.Join(tempDir, "server.crt")
|
||
keyFile := filepath.Join(tempDir, "server.key")
|
||
|
||
generateTestCertificate(t, certFile, keyFile)
|
||
|
||
cfg := config.StreamSSLConfig{
|
||
Enabled: true,
|
||
Cert: certFile,
|
||
Key: keyFile,
|
||
Protocols: []string{"TLSv1.2", "TLSv1.3"},
|
||
}
|
||
|
||
mgr, err := NewSSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewSSLManager failed: %v", err)
|
||
}
|
||
|
||
if !mgr.IsEnabled() {
|
||
t.Error("Expected IsEnabled to be true")
|
||
}
|
||
|
||
tlsConfig := mgr.GetTLSConfig()
|
||
if tlsConfig == nil {
|
||
t.Fatal("Expected non-nil TLS config")
|
||
}
|
||
|
||
if len(tlsConfig.Certificates) != 1 {
|
||
t.Errorf("Expected 1 certificate, got %d", len(tlsConfig.Certificates))
|
||
}
|
||
|
||
if tlsConfig.MinVersion < tls.VersionTLS12 {
|
||
t.Errorf("Expected MinVersion >= TLS 1.2, got %v", tlsConfig.MinVersion)
|
||
}
|
||
}
|
||
|
||
func TestNewSSLManager_InvalidCert(t *testing.T) {
|
||
cfg := config.StreamSSLConfig{
|
||
Enabled: true,
|
||
Cert: "/nonexistent/cert.pem",
|
||
Key: "/nonexistent/key.pem",
|
||
}
|
||
|
||
_, err := NewSSLManager(cfg)
|
||
if err == nil {
|
||
t.Error("Expected error for invalid certificate path")
|
||
}
|
||
}
|
||
|
||
func TestNewProxySSLManager_Disabled(t *testing.T) {
|
||
cfg := config.StreamProxySSLConfig{
|
||
Enabled: false,
|
||
}
|
||
|
||
mgr, err := NewProxySSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewProxySSLManager failed: %v", err)
|
||
}
|
||
|
||
if mgr.IsEnabled() {
|
||
t.Error("Expected IsEnabled to be false")
|
||
}
|
||
|
||
tlsConfig := mgr.GetClientTLSConfig("example.com")
|
||
if tlsConfig != nil {
|
||
t.Error("Expected nil TLS config when disabled")
|
||
}
|
||
}
|
||
|
||
func TestNewProxySSLManager_Enabled(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
certFile := filepath.Join(tempDir, "client.crt")
|
||
keyFile := filepath.Join(tempDir, "client.key")
|
||
|
||
generateTestCertificate(t, certFile, keyFile)
|
||
|
||
cfg := config.StreamProxySSLConfig{
|
||
Enabled: true,
|
||
Cert: certFile,
|
||
Key: keyFile,
|
||
ServerName: "backend.example.com",
|
||
Verify: false,
|
||
Protocols: []string{"TLSv1.2", "TLSv1.3"},
|
||
SessionReuse: true,
|
||
}
|
||
|
||
mgr, err := NewProxySSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewProxySSLManager failed: %v", err)
|
||
}
|
||
|
||
if !mgr.IsEnabled() {
|
||
t.Error("Expected IsEnabled to be true")
|
||
}
|
||
|
||
tlsConfig := mgr.GetClientTLSConfig("fallback.example.com")
|
||
if tlsConfig == nil {
|
||
t.Fatal("Expected non-nil TLS config")
|
||
}
|
||
|
||
// 应该使用配置中的 ServerName
|
||
if tlsConfig.ServerName != "backend.example.com" {
|
||
t.Errorf("Expected ServerName 'backend.example.com', got '%s'", tlsConfig.ServerName)
|
||
}
|
||
|
||
// 应该有客户端证书
|
||
if len(tlsConfig.Certificates) != 1 {
|
||
t.Errorf("Expected 1 client certificate, got %d", len(tlsConfig.Certificates))
|
||
}
|
||
|
||
// 跳过验证
|
||
if !tlsConfig.InsecureSkipVerify {
|
||
t.Error("Expected InsecureSkipVerify to be true")
|
||
}
|
||
|
||
// 会话复用
|
||
if tlsConfig.ClientSessionCache == nil {
|
||
t.Error("Expected ClientSessionCache to be set")
|
||
}
|
||
}
|
||
|
||
func TestNewProxySSLManager_WithVerify(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
caFile := filepath.Join(tempDir, "ca.crt")
|
||
|
||
// 创建 CA 证书
|
||
template := &x509.Certificate{
|
||
SerialNumber: big.NewInt(1),
|
||
NotBefore: time.Now(),
|
||
NotAfter: time.Now().Add(24 * time.Hour),
|
||
IsCA: true,
|
||
KeyUsage: x509.KeyUsageCertSign | x509.KeyUsageCRLSign,
|
||
BasicConstraintsValid: true,
|
||
}
|
||
|
||
key, err := rsa.GenerateKey(rand.Reader, 2048)
|
||
if err != nil {
|
||
t.Fatalf("Failed to generate key: %v", err)
|
||
}
|
||
|
||
certDER, err := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create CA certificate: %v", err)
|
||
}
|
||
|
||
caOut, err := os.Create(caFile)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create CA file: %v", err)
|
||
}
|
||
defer func() { _ = caOut.Close() }()
|
||
if err := pem.Encode(caOut, &pem.Block{Type: "CERTIFICATE", Bytes: certDER}); err != nil {
|
||
t.Fatalf("Failed to encode CA: %v", err)
|
||
}
|
||
|
||
cfg := config.StreamProxySSLConfig{
|
||
Enabled: true,
|
||
Verify: true,
|
||
TrustedCA: caFile,
|
||
ServerName: "backend.example.com",
|
||
}
|
||
|
||
mgr, err := NewProxySSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewProxySSLManager failed: %v", err)
|
||
}
|
||
|
||
tlsConfig := mgr.GetClientTLSConfig("")
|
||
if tlsConfig == nil {
|
||
t.Fatal("Expected non-nil TLS config")
|
||
}
|
||
|
||
// 应该验证证书
|
||
if tlsConfig.InsecureSkipVerify {
|
||
t.Error("Expected InsecureSkipVerify to be false")
|
||
}
|
||
|
||
// 应该有 RootCAs
|
||
if tlsConfig.RootCAs == nil {
|
||
t.Error("Expected RootCAs to be set")
|
||
}
|
||
}
|
||
|
||
func TestParseMinTLSVersion(t *testing.T) {
|
||
tests := []struct {
|
||
protocols []string
|
||
wantVersion uint16
|
||
}{
|
||
{[]string{"TLSv1.3"}, tls.VersionTLS13},
|
||
{[]string{"TLSv1.2"}, tls.VersionTLS12},
|
||
{[]string{"TLSv1.2", "TLSv1.3"}, tls.VersionTLS12},
|
||
{[]string{}, tls.VersionTLS12},
|
||
{[]string{"Unknown"}, tls.VersionTLS12},
|
||
}
|
||
|
||
for _, tt := range tests {
|
||
got := parseMinTLSVersion(tt.protocols)
|
||
if got != tt.wantVersion {
|
||
t.Errorf("parseMinTLSVersion(%v) = %v, want %v", tt.protocols, got, tt.wantVersion)
|
||
}
|
||
}
|
||
}
|
||
|
||
func TestParseCipherSuites(t *testing.T) {
|
||
tests := []struct {
|
||
name string
|
||
ciphers []string
|
||
wantLen int
|
||
}{
|
||
{
|
||
name: "valid ciphers",
|
||
ciphers: []string{"ECDHE-RSA-AES128-GCM-SHA256", "ECDHE-RSA-AES256-GCM-SHA384"},
|
||
wantLen: 2,
|
||
},
|
||
{
|
||
name: "empty ciphers",
|
||
ciphers: []string{},
|
||
wantLen: 0, // returns nil for empty
|
||
},
|
||
{
|
||
name: "unknown ciphers",
|
||
ciphers: []string{"UNKNOWN-CIPHER"},
|
||
wantLen: 0, // returns nil for no valid ciphers
|
||
},
|
||
}
|
||
|
||
for _, tt := range tests {
|
||
t.Run(tt.name, func(t *testing.T) {
|
||
got := parseCipherSuites(tt.ciphers)
|
||
if tt.wantLen == 0 && got != nil {
|
||
t.Errorf("Expected nil, got %v", got)
|
||
} else if tt.wantLen > 0 && len(got) != tt.wantLen {
|
||
t.Errorf("Expected %d ciphers, got %d", tt.wantLen, len(got))
|
||
}
|
||
})
|
||
}
|
||
}
|
||
|
||
func TestLoadCertPool(t *testing.T) {
|
||
t.Run("valid cert", func(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
certFile := filepath.Join(tempDir, "ca.crt")
|
||
|
||
// 创建证书
|
||
template := &x509.Certificate{
|
||
SerialNumber: big.NewInt(1),
|
||
NotBefore: time.Now(),
|
||
NotAfter: time.Now().Add(24 * time.Hour),
|
||
IsCA: true,
|
||
KeyUsage: x509.KeyUsageCertSign,
|
||
}
|
||
|
||
key, _ := rsa.GenerateKey(rand.Reader, 2048)
|
||
certDER, _ := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
|
||
|
||
certOut, err := os.Create(certFile)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create cert file: %v", err)
|
||
}
|
||
defer func() { _ = certOut.Close() }()
|
||
if err := pem.Encode(certOut, &pem.Block{Type: "CERTIFICATE", Bytes: certDER}); err != nil {
|
||
t.Fatalf("Failed to encode certificate: %v", err)
|
||
}
|
||
|
||
pool, err := sslutil.LoadCertPool(certFile, "test")
|
||
if err != nil {
|
||
t.Fatalf("loadCertPool failed: %v", err)
|
||
}
|
||
if pool == nil {
|
||
t.Error("Expected non-nil pool")
|
||
}
|
||
})
|
||
|
||
t.Run("invalid path", func(t *testing.T) {
|
||
_, err := sslutil.LoadCertPool("/nonexistent/cert.pem", "test")
|
||
if err == nil {
|
||
t.Error("Expected error for nonexistent file")
|
||
}
|
||
})
|
||
|
||
t.Run("invalid content", func(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
certFile := filepath.Join(tempDir, "invalid.crt")
|
||
if err := os.WriteFile(certFile, []byte("not a certificate"), 0o644); err != nil {
|
||
t.Fatalf("写入无效证书文件失败: %v", err)
|
||
}
|
||
|
||
_, err := sslutil.LoadCertPool(certFile, "test")
|
||
if err == nil {
|
||
t.Error("Expected error for invalid certificate content")
|
||
}
|
||
})
|
||
}
|
||
|
||
func TestSSLManager_GetTLSConfig_WithClientCA(t *testing.T) {
|
||
tempDir := t.TempDir()
|
||
certFile := filepath.Join(tempDir, "server.crt")
|
||
keyFile := filepath.Join(tempDir, "server.key")
|
||
caFile := filepath.Join(tempDir, "ca.crt")
|
||
|
||
generateTestCertificate(t, certFile, keyFile)
|
||
|
||
// 创建 CA 证书
|
||
template := &x509.Certificate{
|
||
SerialNumber: big.NewInt(1),
|
||
NotBefore: time.Now(),
|
||
NotAfter: time.Now().Add(24 * time.Hour),
|
||
IsCA: true,
|
||
KeyUsage: x509.KeyUsageCertSign,
|
||
BasicConstraintsValid: true,
|
||
}
|
||
|
||
key, _ := rsa.GenerateKey(rand.Reader, 2048)
|
||
certDER, _ := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
|
||
|
||
caOut, err := os.Create(caFile)
|
||
if err != nil {
|
||
t.Fatalf("Failed to create CA file: %v", err)
|
||
}
|
||
defer func() { _ = caOut.Close() }()
|
||
if err := pem.Encode(caOut, &pem.Block{Type: "CERTIFICATE", Bytes: certDER}); err != nil {
|
||
t.Fatalf("Failed to encode CA: %v", err)
|
||
}
|
||
|
||
cfg := config.StreamSSLConfig{
|
||
Enabled: true,
|
||
Cert: certFile,
|
||
Key: keyFile,
|
||
ClientCA: caFile,
|
||
Protocols: []string{"TLSv1.2"},
|
||
}
|
||
|
||
mgr, err := NewSSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewSSLManager failed: %v", err)
|
||
}
|
||
|
||
tlsConfig := mgr.GetTLSConfig()
|
||
if tlsConfig == nil {
|
||
t.Fatal("Expected non-nil TLS config")
|
||
}
|
||
|
||
// 应该配置客户端 CA
|
||
if tlsConfig.ClientCAs == nil {
|
||
t.Error("Expected ClientCAs to be set")
|
||
}
|
||
|
||
// 应该请求客户端证书
|
||
if tlsConfig.ClientAuth != tls.VerifyClientCertIfGiven {
|
||
t.Errorf("Expected ClientAuth VerifyClientCertIfGiven, got %v", tlsConfig.ClientAuth)
|
||
}
|
||
}
|
||
|
||
func TestProxySSLManager_GetClientTLSConfig_WithServerNameOverride(t *testing.T) {
|
||
cfg := config.StreamProxySSLConfig{
|
||
Enabled: true,
|
||
Verify: false,
|
||
ServerName: "configured.example.com",
|
||
}
|
||
|
||
mgr, err := NewProxySSLManager(cfg)
|
||
if err != nil {
|
||
t.Fatalf("NewProxySSLManager failed: %v", err)
|
||
}
|
||
|
||
// 即使传入不同的 serverName，也应该使用配置的
|
||
tlsConfig := mgr.GetClientTLSConfig("fallback.example.com")
|
||
if tlsConfig == nil {
|
||
t.Fatal("Expected non-nil TLS config")
|
||
}
|
||
|
||
if tlsConfig.ServerName != "configured.example.com" {
|
||
t.Errorf("Expected ServerName 'configured.example.com', got '%s'", tlsConfig.ServerName)
|
||
}
|
||
}
|