From ecb020fed9d7343bcea8d4889b9ec06f8351f842 Mon Sep 17 00:00:00 2001
From: xfy <i@rua.plus>
Date: Wed, 29 Apr 2026 18:22:02 +0800
Subject: [PATCH] refactor(security): extract auth_request defaults helper

Extract applyDefaults function to unify configuration initialization
logic between NewAuthRequest and UpdateConfig methods.

Eliminates ~20 lines of duplicate default value setting code.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 internal/middleware/security/auth_request.go | 66 +++++++-------------
 1 file changed, 23 insertions(+), 43 deletions(-)

diff --git a/internal/middleware/security/auth_request.go b/internal/middleware/security/auth_request.go
index 71ac9de..ebc8e47 100644
--- a/internal/middleware/security/auth_request.go
+++ b/internal/middleware/security/auth_request.go
@@ -59,6 +59,27 @@ type AuthRequest struct {
 	mu sync.RWMutex
 }
 
+// applyDefaults 设置配置默认值。
+func applyDefaults(cfg *config.AuthRequestConfig) {
+	if cfg.Method == "" {
+		cfg.Method = "GET"
+	}
+	cfg.Method = strings.ToUpper(cfg.Method)
+
+	if cfg.Timeout == 0 {
+		cfg.Timeout = 5 * time.Second
+	}
+
+	if cfg.ForwardHeaders == nil {
+		cfg.ForwardHeaders = []string{
+			"Cookie",
+			"Authorization",
+			"X-Forwarded-For",
+			"X-Real-Ip",
+		}
+	}
+}
+
 // NewAuthRequest 使用给定的配置创建一个新的 AuthRequest 中间件。
 //
 // 参数：
@@ -76,28 +97,7 @@ func NewAuthRequest(cfg config.AuthRequestConfig) (*AuthRequest, error) {
 		return nil, errors.New("auth_request: uri is required")
 	}
 
-	// 设置默认值
-	method := cfg.Method
-	if method == "" {
-		method = "GET"
-	}
-	cfg.Method = strings.ToUpper(method)
-
-	timeout := cfg.Timeout
-	if timeout == 0 {
-		timeout = 5 * time.Second
-	}
-	cfg.Timeout = timeout
-
-	// 设置默认转发头
-	if cfg.ForwardHeaders == nil {
-		cfg.ForwardHeaders = []string{
-			"Cookie",
-			"Authorization",
-			"X-Forwarded-For",
-			"X-Real-Ip",
-		}
-	}
+	applyDefaults(&cfg)
 
 	ar := &AuthRequest{
 		config: cfg,
@@ -366,27 +366,7 @@ func (a *AuthRequest) UpdateConfig(cfg config.AuthRequestConfig) error {
 		return errors.New("auth_request: uri is required")
 	}
 
-	// 设置默认值
-	method := cfg.Method
-	if method == "" {
-		method = "GET"
-	}
-	cfg.Method = strings.ToUpper(method)
-
-	timeout := cfg.Timeout
-	if timeout == 0 {
-		timeout = 5 * time.Second
-	}
-	cfg.Timeout = timeout
-
-	if cfg.ForwardHeaders == nil {
-		cfg.ForwardHeaders = []string{
-			"Cookie",
-			"Authorization",
-			"X-Forwarded-For",
-			"X-Real-Ip",
-		}
-	}
+	applyDefaults(&cfg)
 
 	a.mu.Lock()
 	a.config = cfg