mirror of
https://github.com/neovim/neovim
synced 2025-07-16 01:01:49 +00:00
c4e52d604c
Problem: spurious CursorHold triggered in GUI on startup
Solution: init global did_cursorhold flag to true
(Gary Johnson)
When Vim is started in GUI mode, the CursorHold autocommand event is
triggered 'updatetime' milliseconds later, even when the user has not
pressed a key. This is different from the behavior of Vim in terminal
mode, which does not trigger a CursorHold autocommand event at startup,
and contradicts the description of the CursorHold event in ":help
CursorHold", which states that the event is "[n]ot triggered until the
user has pressed a key".
The fix is to change the initial value of did_cursorhold from FALSE to
TRUE. While it is true that the CursorDone event has not been done yet
at startup, it should appear to have been done until the user presses
a key.
fixes vim/vim#17350
closes: vim/vim#17382
318ff9c362
Co-authored-by: Gary Johnson <garyjohn@spocom.com>
102 lines
2.7 KiB
Lua
102 lines
2.7 KiB
Lua
local t = require('test.testutil')
|
|
local n = require('test.functional.testnvim')()
|
|
|
|
local clear = n.clear
|
|
local eq = t.eq
|
|
local feed = n.feed
|
|
local retry = t.retry
|
|
local exec = n.source
|
|
local sleep = vim.uv.sleep
|
|
local api = n.api
|
|
|
|
before_each(clear)
|
|
|
|
describe('CursorHold', function()
|
|
before_each(function()
|
|
exec([[
|
|
let g:cursorhold = 0
|
|
augroup test
|
|
au CursorHold * let g:cursorhold += 1
|
|
augroup END
|
|
]])
|
|
end)
|
|
|
|
it('is triggered correctly #12587', function()
|
|
local function test_cursorhold(fn, early)
|
|
local ut = 2
|
|
-- if testing with small 'updatetime' fails, double its value and test again
|
|
retry(10, nil, function()
|
|
ut = ut * 2
|
|
api.nvim_set_option_value('updatetime', ut, {})
|
|
feed('0') -- reset did_cursorhold
|
|
api.nvim_set_var('cursorhold', 0)
|
|
sleep(ut / 4)
|
|
fn()
|
|
eq(0, api.nvim_get_var('cursorhold'))
|
|
sleep(ut / 2)
|
|
fn()
|
|
eq(0, api.nvim_get_var('cursorhold'))
|
|
sleep(ut / 2)
|
|
eq(early, api.nvim_get_var('cursorhold'))
|
|
sleep(ut / 4 * 3)
|
|
eq(1, api.nvim_get_var('cursorhold'))
|
|
end)
|
|
end
|
|
|
|
local ignore_key = api.nvim_replace_termcodes('<Ignore>', true, true, true)
|
|
test_cursorhold(function() end, 1)
|
|
test_cursorhold(function()
|
|
feed('')
|
|
end, 1)
|
|
test_cursorhold(function()
|
|
api.nvim_feedkeys('', 'n', true)
|
|
end, 1)
|
|
test_cursorhold(function()
|
|
feed('<Ignore>')
|
|
end, 0)
|
|
test_cursorhold(function()
|
|
api.nvim_feedkeys(ignore_key, 'n', true)
|
|
end, 0)
|
|
end)
|
|
|
|
it("reducing 'updatetime' while waiting for CursorHold #20241", function()
|
|
api.nvim_set_option_value('updatetime', 10000, {})
|
|
feed('0') -- reset did_cursorhold
|
|
api.nvim_set_var('cursorhold', 0)
|
|
sleep(50)
|
|
eq(0, api.nvim_get_var('cursorhold'))
|
|
api.nvim_set_option_value('updatetime', 20, {})
|
|
sleep(10)
|
|
eq(1, api.nvim_get_var('cursorhold'))
|
|
end)
|
|
|
|
it('is not triggered after only K_EVENT on startup', function()
|
|
api.nvim_set_option_value('updatetime', 20, {})
|
|
sleep(50)
|
|
eq(0, api.nvim_get_var('cursorhold'))
|
|
feed('0')
|
|
sleep(50)
|
|
eq(1, api.nvim_get_var('cursorhold'))
|
|
end)
|
|
end)
|
|
|
|
describe('CursorHoldI', function()
|
|
-- NOTE: since this test uses RPC it is not necessary to trigger the initial
|
|
-- issue (#3757) via timer's or RPC callbacks in the first place.
|
|
it('is triggered after input', function()
|
|
exec([[
|
|
set updatetime=1
|
|
|
|
let g:cursorhold = 0
|
|
augroup test
|
|
au CursorHoldI * let g:cursorhold += 1
|
|
augroup END
|
|
]])
|
|
feed('ifoo')
|
|
retry(5, nil, function()
|
|
sleep(1)
|
|
eq(1, api.nvim_get_var('cursorhold'))
|
|
end)
|
|
end)
|
|
end)
|