From d74c74aae35e79591426bac786a02c8b008cef5d Mon Sep 17 00:00:00 2001 From: dundargoc Date: Mon, 23 Dec 2024 13:16:42 +0100 Subject: [PATCH] build: remove `lintcommit` from `lint` target Previously, `make lint` would invoke `lintcommit` which would fail if there were fixup or other disallowed commits. This would disrupt local development as developers would often want non-commit linting to work early on without needing to adhere to the strict commit rules. --- CMakeLists.txt | 2 +- CONTRIBUTING.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ae5704cfe4..a19c04c26f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -271,7 +271,7 @@ add_custom_target(lintcommit add_dependencies(lintcommit nvim_bin) add_custom_target(lint) -add_dependencies(lint lintc lintlua lintsh lintcommit) +add_dependencies(lint lintc lintlua lintsh) # Format add_glob_target( diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f40d4c54b7..324cb3e13a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,7 +83,7 @@ a comment. ### Commit messages Follow the [conventional commits guidelines][conventional_commits] to *make reviews easier* and to make -the VCS/git logs more valuable. The structure of a commit message is: +the VCS/git logs more valuable (try `make lintcommit`). The structure of a commit message is: type(scope): subject