From b3bdba5cb10f9f0f1f2b40ff40e807f8a22f65c1 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Tue, 31 Dec 2024 13:55:38 +0100 Subject: [PATCH] ci(news): trigger job for `perf` commit type There is a "performance" section in news.txt so it makes sense we should also give a reminder to update news for performance improvements. --- .github/workflows/news.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/news.yml b/.github/workflows/news.yml index 8d21b86e8e..ca07876197 100644 --- a/.github/workflows/news.yml +++ b/.github/workflows/news.yml @@ -19,15 +19,15 @@ jobs: message=$(git log -n1 --pretty=format:%s $commit) type="$(echo "$message" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" breaking="$(echo "$message" | sed -E 's|[[:alpha:]]+(\(.*\))?!:.*|breaking-change|')" - if [[ "$type" == "feat" ]] || [[ "$breaking" == "breaking-change" ]]; then + if [[ "$type" == "feat" ]] || [[ "$type" == "perf" ]] || [[ "$breaking" == "breaking-change" ]]; then ! git diff HEAD~${{ github.event.pull_request.commits }}..HEAD --quiet runtime/doc/news.txt || { echo " - Pull request includes a new feature or a breaking change, but - news.txt hasn't been updated yet. This is just a reminder - that news.txt may need to be updated. You can ignore this CI - failure if you think the change won't be of interest to - users." + Pull request includes a new feature, performance improvement + or a breaking change, but news.txt hasn't been updated yet. + This is just a reminder that news.txt may need to be updated. + You can ignore this CI failure if you think the change won't + be of interest to users." exit 1 } fi