fix(popup): reuse pum preview float win, set 'winfixbuf' #32636

Problem:
popup floating window is closed and recreated for each item selection,
this is a bit wasteful.

Solution:
- Hide the preview win (instead of closing it) when the menu is still displayed:
    1. When selected_item is -1.
    2. When switching from an item with an "info" field to one without.
- When pum is undisplayed it is still closed.

src/nvim/popupmenu.c

@@ -871,6 +871,7 @@ win_T *pum_set_info(int selected, char *info)
     if (!wp) {
       return NULL;
     }
+    wp->w_p_wfb = true;
   }
   linenr_T lnum = 0;
   int max_info_width = 0;
@@ -915,7 +916,8 @@ static bool pum_set_selected(int n, int repeat)
   if (use_float && (pum_selected < 0 || pum_array[pum_selected].pum_info == NULL)) {
     win_T *wp = win_float_find_preview();
     if (wp) {
-      win_close(wp, true, true);
+      wp->w_config.hide = true;
+      win_config_float(wp, wp->w_config);
     }
   }
 

test/functional/ui/popupmenu_spec.lua

@@ -1862,9 +1862,21 @@ describe('builtin popupmenu', function()
               {1:~                                       }|*9
             ## grid 3
               {2:-- }{8:Back at original}                     |
+            ## grid 4 (hidden)
+              {n:1info}|
+              {n:     }|
             ## grid 5
               {n:one            }|
             ]],
+            win_pos = {
+              [2] = {
+                height = 10,
+                startcol = 0,
+                startrow = 0,
+                width = 40,
+                win = 1000,
+              },
+            },
             float_pos = {
               [5] = { -1, 'NW', 2, 1, 0, false, 100 },
             },
@@ -1878,6 +1890,15 @@ describe('builtin popupmenu', function()
                 linecount = 1,
                 sum_scroll_delta = 0,
               },
+              [4] = {
+                win = 1001,
+                topline = 0,
+                botline = 2,
+                curline = 0,
+                curcol = 0,
+                linecount = 1,
+                sum_scroll_delta = 0,
+              },
             },
             win_viewport_margins = {
               [2] = {
@@ -1887,6 +1908,13 @@ describe('builtin popupmenu', function()
                 top = 0,
                 win = 1000,
               },
+              [4] = {
+                bottom = 0,
+                left = 0,
+                right = 0,
+                top = 0,
+                win = 1001,
+              },
             },
           })
         else
@@ -1903,7 +1931,7 @@ describe('builtin popupmenu', function()
         -- test nvim__complete_set_info
         feed('<ESC>S<C-X><C-O><C-N><C-N>')
         if multigrid then
-          screen:expect {
+          screen:expect({
             grid = [[
             ## grid 1
               [2:----------------------------------------]|*10
@@ -1917,13 +1945,22 @@ describe('builtin popupmenu', function()
               {n:one                }|
               {n:two                }|
               {s:looooooooooooooong }|
-          ## grid 7
+            ## grid 6
               {n:3info}|
               {n:     }|
             ]],
+            win_pos = {
+              [2] = {
+                height = 10,
+                startcol = 0,
+                startrow = 0,
+                width = 40,
+                win = 1000,
+              },
+            },
             float_pos = {
               [5] = { -1, 'NW', 2, 1, 0, false, 100 },
-              [7] = { 1003, 'NW', 1, 1, 19, false, 50 },
+              [6] = { 1002, 'NW', 1, 1, 19, false, 50 },
             },
             win_viewport = {
               [2] = {
@@ -1935,8 +1972,8 @@ describe('builtin popupmenu', function()
                 linecount = 1,
                 sum_scroll_delta = 0,
               },
-              [7] = {
+              [6] = {
-                win = 1003,
+                win = 1002,
                 topline = 0,
                 botline = 2,
                 curline = 0,
@@ -1945,7 +1982,23 @@ describe('builtin popupmenu', function()
                 sum_scroll_delta = 0,
               },
             },
-          }
+            win_viewport_margins = {
+              [2] = {
+                bottom = 0,
+                left = 0,
+                right = 0,
+                top = 0,
+                win = 1000,
+              },
+              [6] = {
+                bottom = 0,
+                left = 0,
+                right = 0,
+                top = 0,
+                win = 1002,
+              },
+            },
+          })
         else
           screen:expect {
             grid = [[
@@ -1964,7 +2017,7 @@ describe('builtin popupmenu', function()
         insert(('test'):rep(5))
         feed('i<C-x><C-o>')
         if multigrid then
-          screen:expect {
+          screen:expect({
             grid = [[
             ## grid 1
               [2:----------------------------------------]|*10
@@ -1978,12 +2031,21 @@ describe('builtin popupmenu', function()
               {s: one                }|
               {n: two                }|
               {n: looooooooooooooong }|
-          ## grid 8
+            ## grid 7
               {n:1info}|
               {n:     }|
             ]],
+            win_pos = {
+              [2] = {
+                height = 10,
+                startcol = 0,
+                startrow = 0,
+                width = 40,
+                win = 1000,
+              },
+            },
             float_pos = {
-              [8] = { 1004, 'NW', 1, 1, 14, false, 50 },
+              [7] = { 1003, 'NW', 1, 1, 14, false, 50 },
               [5] = { -1, 'NW', 2, 1, 19, false, 100 },
             },
             win_viewport = {
@@ -1996,8 +2058,8 @@ describe('builtin popupmenu', function()
                 linecount = 1,
                 sum_scroll_delta = 0,
               },
-              [8] = {
+              [7] = {
-                win = 1004,
+                win = 1003,
                 topline = 0,
                 botline = 2,
                 curline = 0,
@@ -2006,7 +2068,23 @@ describe('builtin popupmenu', function()
                 sum_scroll_delta = 0,
               },
             },
-          }
+            win_viewport_margins = {
+              [2] = {
+                bottom = 0,
+                left = 0,
+                right = 0,
+                top = 0,
+                win = 1000,
+              },
+              [7] = {
+                bottom = 0,
+                left = 0,
+                right = 0,
+                top = 0,
+                win = 1003,
+              },
+            },
+          })
         else
           screen:expect {
             grid = [[
@@ -2039,7 +2117,7 @@ describe('builtin popupmenu', function()
               {s:one                }|
               {n:two                }|
               {n:looooooooooooooong }|
-            ## grid 9
+            ## grid 8
               {n:```lua         }|
               {n:function test()}|
               {n:  print('foo') }|
@@ -2047,9 +2125,18 @@ describe('builtin popupmenu', function()
               {n:```            }|
               {n:               }|
             ]],
+            win_pos = {
+              [2] = {
+                height = 10,
+                startcol = 0,
+                startrow = 0,
+                width = 40,
+                win = 1000,
+              },
+            },
             float_pos = {
               [5] = { -1, 'NW', 2, 1, 0, false, 100 },
-              [9] = { 1005, 'NW', 1, 1, 19, false, 50 },
+              [8] = { 1004, 'NW', 1, 1, 19, false, 50 },
             },
             win_viewport = {
               [2] = {
@@ -2061,8 +2148,8 @@ describe('builtin popupmenu', function()
                 linecount = 1,
                 sum_scroll_delta = 0,
               },
-              [9] = {
+              [8] = {
-                win = 1005,
+                win = 1004,
                 topline = 0,
                 botline = 6,
                 curline = 0,
@@ -2079,12 +2166,12 @@ describe('builtin popupmenu', function()
                 top = 0,
                 win = 1000,
               },
-              [9] = {
+              [8] = {
                 bottom = 0,
                 left = 0,
                 right = 0,
                 top = 0,
-                win = 1005,
+                win = 1004,
               },
             },
           })