GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-15 16:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): open_floating_preview() ignores max_height (#32716)

Browse Source 
Problem:  After 47aaddfa the max_height option is no longer respected.
          Hover documentation and Signature help windows take up the
          entire text height.
Solution: Compare to window's current height and only modify the height
          if it would reduce the height, not enlarge it.
This commit is contained in:
Robert Muir
2025-03-04 13:36:57 -05:00
committed by GitHub
parent fb842dfc22
commit 7d5866d471
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
runtime/lua/vim/lsp/util.lua
View File

@ -1656,7 +1656,9 @@ function M.open_floating_preview(contents, syntax, opts)
if not opts.height then
-- Reduce window height if TS highlighter conceals code block backticks.
local conceal_height = api.nvim_win_text_height(floating_winnr, {}).all
api.nvim_win_set_height(floating_winnr, conceal_height)
if conceal_height < api.nvim_win_get_height(floating_winnr) then
api.nvim_win_set_height(floating_winnr, conceal_height)
end
end
end

24
test/functional/plugin/lsp/utils_spec.lua
View File

@ -383,4 +383,28 @@ describe('vim.lsp.util', function()
|
]])
end)
it('open_floating_preview height does not exceed max_height', function()
local screen = Screen.new()
exec_lua([[
vim.lsp.util.open_floating_preview(vim.fn.range(1, 10), 'markdown', {
border = 'single',
width = 5,
max_height = 5,
focus = false,
})
]])
screen:expect([[
^ |
┌─────┐{1: }|
│{4:1 }│{1: }|
│{4:2 }│{1: }|
│{4:3 }│{1: }|
│{4:4 }│{1: }|
│{4:5 }│{1: }|
└─────┘{1: }|
{1:~ }|*5
|
]])
end)
end)