GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 01:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(window): :close crash with autocmd, floats and tabpage (#27793)

Browse Source 
Problem:  :close crash with autocmd, floats and tabpage.
Solution: Close floating windows in one more case.
This commit is contained in:
zeertzjq
2024-03-10 07:55:04 +08:00
committed by GitHub
parent 448cf10c47
commit 731e7f51ee
2 changed files with 42 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/functional/ui/float_spec.lua
View File

@ -874,34 +874,38 @@ describe('float window', function()
end)
describe(':close on non-float with floating windows', function()
-- XXX: it isn't really clear whether this should quit Nvim, as if the autocommand
-- here is BufUnload then it does quit Nvim.
-- But with BufWinLeave, this doesn't quit Nvim if there are no floating windows,
-- so it shouldn't quit Nvim if there are floating windows.
it('does not quit Nvim if BufWinLeave makes it the only non-float', function()
exec([[
let firstbuf = bufnr()
let g:buf = bufnr()
new
let midwin = win_getid()
let s:midwin = win_getid()
new
setlocal bufhidden=wipe
call nvim_win_set_config(midwin,
call nvim_win_set_config(s:midwin,
\ #{relative: 'editor', row: 5, col: 5, width: 5, height: 5})
autocmd BufWinLeave * ++once exe firstbuf .. 'bwipe!'
autocmd BufWinLeave * ++once exe g:buf .. 'bwipe!'
]])
eq('Vim(close):E855: Autocommands caused command to abort', pcall_err(command, 'close'))
assert_alive()
end)
pending('does not crash if BufWinLeave makes it the only non-float in tabpage', function()
it('does not crash if BufUnload makes it the only non-float in tabpage', function()
exec([[
tabnew
let firstbuf = bufnr()
let g:buf = bufnr()
new
let midwin = win_getid()
let s:midwin = win_getid()
new
setlocal bufhidden=wipe
call nvim_win_set_config(midwin,
call nvim_win_set_config(s:midwin,
\ #{relative: 'editor', row: 5, col: 5, width: 5, height: 5})
autocmd BufWinLeave * ++once exe firstbuf .. 'bwipe!'
autocmd BufUnload * ++once exe g:buf .. 'bwipe!'
]])
eq('Vim(close):E855: Autocommands caused command to abort', pcall_err(command, 'close'))
command('close')
assert_alive()
end)
end)