GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 09:11:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lua): show stacktrace for error in vim.on_key() callback (#31021)

Browse Source
This commit is contained in:
zeertzjq
2024-11-02 10:11:06 +08:00
committed by GitHub
parent b25ae5d328
commit 3688a33354
3 changed files with 39 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
runtime/lua/vim/_editor.lua
View File

@ -701,11 +701,13 @@ end
--- Executes the on_key callbacks.
---@private
function vim._on_key(buf, typed_buf)
local failed_ns_ids = {}
local failed_messages = {}
local failed = {} ---@type [integer, string][]
local discard = false
for k, v in pairs(on_key_cbs) do
local ok, rv = pcall(v[1], buf, typed_buf)
local fn = v[1]
local ok, rv = xpcall(function()
return fn(buf, typed_buf)
end, debug.traceback)
if ok and rv ~= nil then
if type(rv) == 'string' and #rv == 0 then
discard = true
@ -718,19 +720,16 @@ function vim._on_key(buf, typed_buf)
end
if not ok then
vim.on_key(nil, k)
table.insert(failed_ns_ids, k)
table.insert(failed_messages, rv)
table.insert(failed, { k, rv })
end
end
if failed_ns_ids[1] then
error(
string.format(
"Error executing 'on_key' with ns_ids '%s'\n Messages: %s",
table.concat(failed_ns_ids, ', '),
table.concat(failed_messages, '\n')
)
)
if #failed > 0 then
local errmsg = ''
for _, v in ipairs(failed) do
errmsg = errmsg .. string.format('\nWith ns_id %d: %s', v[1], v[2])
end
error(errmsg)
end
return discard
end