From 34fbfa3586c2684b3601c9df3b73c20542545a47 Mon Sep 17 00:00:00 2001 From: Travis Finkenauer Date: Sat, 12 Jul 2025 07:00:36 -0700 Subject: [PATCH] refactor(build): use consistent cmake names #34893 CMake is functions/macros are case-insensitive (unlike variables), but names differing only by case (e.g. "BuildLuaJit" instead of "BuildLuajit") may look the same at a glance. This can be confusing if you do a case-sensitive search, such as by using the * key in neovim to search for other instances of the word under the cursor. --- cmake.deps/cmake/BuildLuajit.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmake.deps/cmake/BuildLuajit.cmake b/cmake.deps/cmake/BuildLuajit.cmake index db37d79099..c8a45b327f 100644 --- a/cmake.deps/cmake/BuildLuajit.cmake +++ b/cmake.deps/cmake/BuildLuajit.cmake @@ -42,7 +42,7 @@ if(APPLE) endif() if(UNIX) - BuildLuaJit(INSTALL_COMMAND ${BUILDCMD_UNIX} + BuildLuajit(INSTALL_COMMAND ${BUILDCMD_UNIX} CC=${DEPS_C_COMPILER} PREFIX=${DEPS_INSTALL_DIR} ${DEPLOYMENT_TARGET} install) @@ -53,7 +53,7 @@ elseif(MINGW) else() set(LUAJIT_MAKE_PRG ${CMAKE_MAKE_PROGRAM}) endif() - BuildLuaJit(BUILD_COMMAND ${LUAJIT_MAKE_PRG} CC=${DEPS_C_COMPILER} + BuildLuajit(BUILD_COMMAND ${LUAJIT_MAKE_PRG} CC=${DEPS_C_COMPILER} PREFIX=${DEPS_INSTALL_DIR} CFLAGS+=-DLUA_USE_APICHECK CFLAGS+=-funwind-tables @@ -75,7 +75,7 @@ elseif(MINGW) ) elseif(MSVC) - BuildLuaJit( + BuildLuajit( BUILD_COMMAND ${CMAKE_COMMAND} -E chdir ${DEPS_BUILD_DIR}/src/luajit/src ${DEPS_BUILD_DIR}/src/luajit/src/msvcbuild.bat INSTALL_COMMAND ${CMAKE_COMMAND} -E make_directory ${DEPS_BIN_DIR} COMMAND ${CMAKE_COMMAND} -E copy ${DEPS_BUILD_DIR}/src/luajit/src/luajit.exe ${DEPS_BIN_DIR}