GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 01:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(window): :close may cause Nvim to quit with autocmd and float

Browse Source 
Problem:  :close may cause Nvim to quit if an autocommand triggered when
          closing the buffer closes all other non-floating windows and
          there are floating windows.
Solution: Correct the check for the only non-floating window.
This commit is contained in:
zeertzjq
2024-03-09 12:47:40 +08:00
parent 6416c6bc94
commit 33dfb5a383
3 changed files with 46 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/functional/ui/float_spec.lua
View File

@ -873,6 +873,39 @@ describe('float window', function()
end)
end)
describe(':close on non-float with floating windows', function()
it('does not quit Nvim if BufWinLeave makes it the only non-float', function()
exec([[
let firstbuf = bufnr()
new
let midwin = win_getid()
new
setlocal bufhidden=wipe
call nvim_win_set_config(midwin,
\ #{relative: 'editor', row: 5, col: 5, width: 5, height: 5})
autocmd BufWinLeave * ++once exe firstbuf .. 'bwipe!'
]])
eq('Vim(close):E855: Autocommands caused command to abort', pcall_err(command, 'close'))
assert_alive()
end)
pending('does not crash if BufWinLeave makes it the only non-float in tabpage', function()
exec([[
tabnew
let firstbuf = bufnr()
new
let midwin = win_getid()
new
setlocal bufhidden=wipe
call nvim_win_set_config(midwin,
\ #{relative: 'editor', row: 5, col: 5, width: 5, height: 5})
autocmd BufWinLeave * ++once exe firstbuf .. 'bwipe!'
]])
eq('Vim(close):E855: Autocommands caused command to abort', pcall_err(command, 'close'))
assert_alive()
end)
end)
local function with_ext_multigrid(multigrid)
local screen, attrs
before_each(function()