GitHub/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim synced 2025-07-16 01:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.1147: preview-window does not scroll correctly

Browse Source 
Problem:  preview-window does not scroll correctly
Solution: init firstline = 0 for a preview window
          (Girish Palya)

The 'info' window, which appears during insert-mode completion to display
additional information, was not scrolling properly when using commands like:
	win_execute(popup_findinfo(), "normal! \<PageDown>")
This issue made it impossible to navigate through info window contents using
keyboard-based scrolling.
The fix correctly updates the w_firstline value of the popup window, ensuring
proper scrolling behavior. Mouse scrolling was already working as expected and
remains unaffected.

closes: vim/vim#16703

12b1eb58ab

Co-authored-by: Girish Palya <girishji@gmail.com>
This commit is contained in:
zeertzjq
2025-05-31 16:49:20 +08:00
parent 33b0a004eb
commit 0af6d6ff5e
1 changed files with 47 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
test/old/testdir/test_ins_complete.vim
View File

@ -473,6 +473,53 @@ func Test_completefunc_info()
set completefunc&
endfunc
func ScrollInfoWindowUserDefinedFn(findstart, query)
" User defined function (i_CTRL-X_CTRL-U)
if a:findstart
return col('.')
endif
let infostr = range(20)->mapnew({_, v -> string(v)})->join("\n")
return [{'word': 'foo', 'info': infostr}, {'word': 'bar'}]
endfunc
func ScrollInfoWindowPageDown()
call win_execute(popup_findinfo(), "normal! \<PageDown>")
return ''
endfunc
func ScrollInfoWindowPageUp()
call win_execute(popup_findinfo(), "normal! \<PageUp>")
return ''
endfunc
func ScrollInfoWindowTest(mvmt, count, fline)
new
set completeopt=menuone,popup,noinsert,noselect
set completepopup=height:5
set completefunc=ScrollInfoWindowUserDefinedFn
let keyseq = "i\<C-X>\<C-U>\<C-N>"
for _ in range(a:count)
let keyseq .= (a:mvmt == "pageup" ? "\<C-R>\<C-R>=ScrollInfoWindowPageUp()\<CR>" :
\ "\<C-R>\<C-R>=ScrollInfoWindowPageDown()\<CR>")
endfor
let keyseq .= "\<C-R>\<C-R>=string(popup_getpos(popup_findinfo()))\<CR>\<ESC>"
call feedkeys(keyseq, "tx")
call assert_match('''firstline'': ' . a:fline, getline(1))
bwipe!
set completeopt&
set completepopup&
set completefunc&
endfunc
func Test_scroll_info_window()
throw 'Skipped: popup_findinfo() is N/A'
call ScrollInfoWindowTest("", 0, 1)
call ScrollInfoWindowTest("pagedown", 1, 4)
call ScrollInfoWindowTest("pagedown", 2, 7)
call ScrollInfoWindowTest("pagedown", 3, 11)
call ScrollInfoWindowTest("pageup", 3, 1)
endfunc
func CompleteInfoUserDefinedFn(findstart, query)
" User defined function (i_CTRL-X_CTRL-U)
if a:findstart